ephraimbuddy commented on code in PR #53699:
URL: https://github.com/apache/airflow/pull/53699#discussion_r2230919329
##########
airflow-core/tests/unit/cli/commands/test_dag_command.py:
##########
@@ -813,7 +813,7 @@ def test_dag_test_with_custom_timetable(self,
mock__get_or_create_dagrun):
)
from airflow.example_dags.plugins.workday import AfterWorkdayTimetable
- with mock.patch.object(AfterWorkdayTimetable, "get_next_workday",
side_effect=[DEFAULT_DATE]):
+ with mock.patch.object(AfterWorkdayTimetable, "get_next_workday",
return_value=DEFAULT_DATE):
Review Comment:
It's exactly two calls, one when syncing the workday dag to the DB and
another when running
[dag.test](https://github.com/apache/airflow/blob/f02b8a865325344923a74c99165a765ae160232a/task-sdk/src/airflow/sdk/definitions/dag.py#L1109).
Should I update the call count? Why I didn't update it is that I'm not sure if
the dag would change in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
