OmerJog commented on issue #6350: [AIRFLOW-5681] Allow specification of a tag or hash for the git_sync init container URL: https://github.com/apache/airflow/pull/6350#issuecomment-550312550 @george-miller The test you added failed: ``` 55) FAIL: test_make_pod_git_sync_rev (tests.kubernetes.test_worker_configuration.TestKubernetesWorkerConfiguration) ---------------------------------------------------------------------- Traceback (most recent call last): tests/kubernetes/test_worker_configuration.py line 444 in test_make_pod_git_sync_rev 'The git_sync_rev env did not get into the init container') AssertionError: {'name': 'GIT_SYNC_REV', 'value': <MagicMock name='mock.git_sync_credentials_secret.to_dict()' id='140691298444512'>, 'value_from': None} not found in [{'name': 'GIT_SYNC_REPO', 'value': <MagicMock name='mock.git_repo.to_dict()' id='140691299285424'>, 'value_from': None}, {'name': 'GIT_SYNC_BRANCH', 'value': <MagicMock name='mock.git_branch.to_dict()' id='140691292267800'>, 'value_from': None}, {'name': 'GIT_SYNC_ROOT', 'value': <MagicMock name='mock.git_sync_root.to_dict()' id='140691300804312'>, 'value_from': None}, {'name': 'GIT_SYNC_DEST', 'value': 'repo', 'value_from': None}, {'name': 'GIT_SYNC_REV', 'value': 'sampletag', 'value_from': None}, {'name': 'GIT_SYNC_DEPTH', 'value': '1', 'value_from': None}, {'name': 'GIT_SYNC_ONE_TIME', 'value': 'true', 'value_from': None}, {'name': 'GIT_SYNC_USERNAME', 'value': <MagicMock name='mock.git_user.to_dict()' id='140691301425448'>, 'value_from': None}, {'name': 'GIT_SYNC_PASSWORD', 'value': <MagicMock name='mock.git_password.to_dict()' id='140691301994848'>, 'value_from': None}, {'name': 'GIT_SYNC_USERNAME', 'value': None, 'value_from': {'config_map_key_ref': None, 'field_ref': None, 'resource_field_ref': None, 'secret_key_ref': {'key': 'GIT_SYNC_USERNAME', 'name': <MagicMock name='mock.git_sync_credentials_secret.to_dict()' id='140691298444512'>, 'optional': None}}}, {'name': 'GIT_SYNC_PASSWORD', 'value': None, 'value_from': {'config_map_key_ref': None, 'field_ref': None, 'resource_field_ref': None, 'secret_key_ref': {'key': 'GIT_SYNC_PASSWORD', 'name': <MagicMock name='mock.git_sync_credentials_secret.to_dict()' id='140691298444512'>, 'optional': None}}}, {'name': 'GIT_SSH_KEY_FILE', 'value': '/etc/git-secret/ssh', 'value_from': None}, {'name': 'GIT_SYNC_SSH', 'value': 'true', 'value_from': None}, {'name': 'GIT_KNOWN_HOSTS', 'value': 'true', 'value_from': None}, {'name': 'GIT_SSH_KNOWN_HOSTS_FILE', 'value': '/etc/git-secret/known_hosts', 'value_from': None}] : The git_sync_rev env did not get into the init container ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
