jedcunningham commented on code in PR #47592:
URL: https://github.com/apache/airflow/pull/47592#discussion_r2237590773
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py:
##########
Review Comment:
Why are these fixtures no longer class scoped?
##########
providers/common/sql/tests/unit/common/sql/operators/test_sql.py:
##########
@@ -56,15 +56,15 @@
from airflow.utils.state import State
from airflow.utils.types import DagRunType
+from tests_common.test_utils.db import clear_db_dag_bundles, clear_db_dags,
clear_db_runs, clear_db_xcom
from tests_common.test_utils.markers import
skip_if_force_lowest_dependencies_marker
from tests_common.test_utils.providers import get_provider_min_airflow_version
from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_1,
AIRFLOW_V_3_0_PLUS
if AIRFLOW_V_3_0_PLUS:
- from airflow.models.xcom import XComModel as XCom
from airflow.utils.types import DagRunTriggeredByType
else:
- from airflow.models.xcom import XCom # type: ignore[no-redef]
+ pass # type: ignore[no-redef]
Review Comment:
Lets just get rid of this else block completely :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
