jscheffl commented on code in PR #53804:
URL: https://github.com/apache/airflow/pull/53804#discussion_r2237877220


##########
airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx:
##########
@@ -188,7 +188,7 @@ export const TaskInstances = () => {
   const { setTableURLState, tableURLState } = useTableURLState();
   const { pagination, sorting } = tableURLState;
   const [sort] = sorting;
-  const orderBy = sort ? [`${sort.desc ? "-" : ""}${sort.id}`] : 
["-start_date"];
+  const orderBy = sort ? [`${sort.desc ? "-" : ""}${sort.id}`] : 
["-map_index", "-start_date"];

Review Comment:
   Yes, the additional sorting is understood. But I was wondering why you sort 
by "map index" _first_ and then by start date. Assuming you have multiple 
dynamically mapped tasks this would first display all mapped tasks by index and 
the others by start date. But all mapped tasks interleaved.
   
   I was asking myself why the sort order is not first by start date and then 
by map index as second criteria. But I am myself not sure if mapped tasks all 
share the same start_date?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to