uranusjr commented on code in PR #51134:
URL: https://github.com/apache/airflow/pull/51134#discussion_r2238044697
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -401,14 +401,16 @@ def write_dag(
# If Yes, does nothing
# If No or the DAG does not exists, updates / writes Serialized DAG to
DB
if min_update_interval is not None:
- if session.scalar(
+ do_nothing = session.scalar(
Review Comment:
Probably better to name this variable something like `has_conflicts`. It
describes what this check actually does a bit better, and the _do nothing_
nature is still implied by the immediate `return False` line. (Not a big deal
though; the comment above explains everything in any case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
