jedcunningham commented on code in PR #52876:
URL: https://github.com/apache/airflow/pull/52876#discussion_r2240751927
##########
airflow-core/tests/unit/cli/commands/test_asset_command.py:
##########
Review Comment:
Why is this being added? Doesn't seem related.
##########
providers/amazon/tests/unit/amazon/aws/bundles/test_s3.py:
##########
@@ -109,9 +109,18 @@ def test_view_url_generates_presigned_url(self):
bundle = S3DagBundle(
name="test", aws_conn_id=AWS_CONN_ID_DEFAULT,
prefix="project1/dags", bucket_name=S3_BUCKET_NAME
)
+
url: str = bundle.view_url("test_version")
assert
url.startswith("https://my-airflow-dags-bucket.s3.amazonaws.com/project1/dags";)
+ @pytest.mark.db_test
+ def test_view_url_template_generates_presigned_url(self):
Review Comment:
Not sure this test name is right, it generates a url, but not a presigned
one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
