amoghrajesh opened a new pull request, #53911:
URL: https://github.com/apache/airflow/pull/53911
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/53908
I have seen some occurrences of `if AIRFLOW_V_3` checks inside core airflow.
This approach has a fundamental circular dependency problem.
You cannot check for version compatibility within the same package you're
checking for because version compatibility checks only make sense when checking
for external dependencies, not when a package is trying to check its own
version for internal import decisions.
Adding a precommit that will prevent such imports in core, didn't complicate
it too much, figured that if its imported, it has to be used.
This is good enough because:
* Targets the root cause - importing version checks into core
* Simple and clear - easy to understand what's being prevented
* Low false positives - won't trigger on comments or string literals
Working example:
```
(airflow) ➜ airflow git:(precommit-to-disallow-af3-imports-in-core) ✗
pre-commit run check-airflow-version-checks-in-core --all-files
No AIRFLOW_V_3* imports in
airflow-core..................................Failed
- hook id: check-airflow-version-checks-in-core
- exit code: 1
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py:27:from
tests_common.test_utils.db import AIRFLOW_V_3_1_PLUS
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_hitl.py:22:from
tests_common.test_utils.db import AIRFLOW_V_3_1_PLUS
airflow-core/tests/unit/listeners/class_listener.py:23:from
tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS
```
Also took this opportunity to do some cleaning of the references. The hitl
ones are covered in https://github.com/apache/airflow/pull/53875 and will
create a follow up PR for `airflow-core/tests/unit/listeners/class_listener.py`
as it might need a certain set of eyes.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
