potiuk commented on PR #53899: URL: https://github.com/apache/airflow/pull/53899#issuecomment-3141375890
While it is good idea in general to make smtp handling more consistent, This change is almost certainly missing a number of things and should be much more "complete" - as it is all about a 'core" functionality. * documentation explaining all the various cases how email can be configured - including some examples of configuring it via connection and configuration * fallback for host/port - seems that for example SMTP mandatory host value is always overwritten by the host value from connection * the type specification in doctsring is "extra" - the type is read from type hints * tests shoudl be added to tests various combinations of the parameter * back-compatibility consideration - likely some notes and newsfragment should be added to explain what the users are supposed to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
