pierrejeambrun commented on code in PR #54008:
URL: https://github.com/apache/airflow/pull/54008#discussion_r2247420597
##########
airflow-core/src/airflow/ui/src/i18n/config.ts:
##########
@@ -37,13 +37,16 @@ export const supportedLanguages = [
export const defaultLanguage = "en";
export const namespaces = ["common", "dashboard", "dags", "admin", "browse",
"assets", "components"] as const;
+const baseUrl = document.querySelector("base")?.href ??
"http://localhost:8080/";;
Review Comment:
Nit: Maybe that? I see we have places with that and places with
`http://locahost:8080/` like here. Maybe keeping it relative to the current url
is the best approach, instead of hardcoding `http://localhost:8080` in case the
base url is not defined ?
```suggestion
const baseUrl = document.querySelector("base")?.href ?? "";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
