ramitkataria commented on code in PR #53831:
URL: https://github.com/apache/airflow/pull/53831#discussion_r2255118898
##########
providers/slack/tests/unit/slack/hooks/test_slack_webhook.py:
##########
@@ -432,6 +432,7 @@ def test_hook_send_dict_legacy_slack_integration(self,
mock_webhook_client_cls,
{"text": "Test Text"},
{"text": "Fallback Text", "blocks": ["Dummy Block"]},
{"text": "Fallback Text", "blocks": ["Dummy Block"],
"unfurl_media": True, "unfurl_links": True},
+ {"legacy": "value"},
Review Comment:
I noticed that it supports other kwargs for legacy integration:
https://github.com/apache/airflow/blob/85de1fe9b80e82db3f7b668bc23f56c66b1f75fc/providers/slack/src/airflow/providers/slack/hooks/slack_webhook.py#L246-L247
But that wasn't being tested in unit tests so I added this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
