ddelange edited a comment on issue #6523: [AIRFLOW-5873] KubernetesPodOperator 
fixes and test
URL: https://github.com/apache/airflow/pull/6523#issuecomment-551736922
 
 
   Hi @potiuk, thanks for the swift reply. I can open a new PR based on master, 
but master is too different from this branch to test my v1.10 setup with these 
changes on our cluster (e.g. my pods won't even start because 
https://github.com/apache/airflow/blob/v1-10-test/airflow/models/user.py 
doesn't exist anymore in master) [?]
   
   To me it seems they have already diverged (master `__version__` is v2.0 
after all) and I'm not sure how those cherry picks would turn out. E.g. I also 
added a fix (base_operator `**resources`) in this PR which is 
[already](https://github.com/apache/airflow/pull/6506#issuecomment-550003258) 
(#6356 1.10.6rc1?) on `master` but not in `v1-test`, but should definitely be 
in v1.10.7
   
   I could alternatively make two PR's, one main one based on `master` and 
merged separately, and make this PR a patch that keeps changes to a minimum 
(with compatibility in mind). Please advise :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to