sjyangkevin commented on issue #54209: URL: https://github.com/apache/airflow/issues/54209#issuecomment-3172818075
The following tests have been done for https://github.com/apache/airflow/pull/54043. In 3.1.0+, should be good, but some caveats we can have a look into it. CC: @Lee-W , @guan404ming ### Unit Test ``` breeze shell --python 3.12 --backend postgres --db-reset pip install apache-airflow-providers-fab==2.4.0rc1 cd providers/fab/tests/unit/ pytest --log-level=INFO -s fab/auth_manager ``` **HITL-related permission test** <img width="1451" height="101" alt="Image" src="https://github.com/user-attachments/assets/afdc318f-430c-4cf7-919b-dc893a15cf4c"; /> **other tests related to fab/auth_manager** <img width="1493" height="147" alt="Image" src="https://github.com/user-attachments/assets/e7942a75-6c12-457d-9f1e-034d92a7d0e6"; /> ### Airflow Manual Functional Test In Airflow < 3.1.0, DAG processor will not start when there is a HITL DAG. <img width="633" height="342" alt="Image" src="https://github.com/user-attachments/assets/9eeace80-efcb-4481-b732-6e184da7702d"; /> In Airflow 3.1.0+ ``` breeze start-airflow --python 3.12 --backend postgres --auth-manager FabAuthManager --db-reset --load-default-connections pip install apache-airflow-providers-fab==2.4.0rc1 >restart all the Airflow services ``` **Initialization** 1. Create a new user 2. Create a new role <img width="1497" height="44" alt="Image" src="https://github.com/user-attachments/assets/24a738ed-7669-4c30-b15d-439b8363d819"; /> <img width="1497" height="44" alt="Image" src="https://github.com/user-attachments/assets/9bac91b1-5373-4be8-9b83-e8986e36e59b"; /> **Test without permission, access is forbidden** <img width="1497" height="44" alt="Image" src="https://github.com/user-attachments/assets/24a738ed-7669-4c30-b15d-439b8363d819"; /> <img width="1567" height="814" alt="Image" src="https://github.com/user-attachments/assets/edd5c2da-6ff5-4072-892a-820a8b357cf3"; /> **Test with permission, access is good task can be triggered, but pop up `409 Conflict` even DAG can be successfully run.** <img width="1525" height="49" alt="Image" src="https://github.com/user-attachments/assets/5513ded6-43b7-42ba-96bb-3b0536900459"; /> <img width="1561" height="827" alt="Image" src="https://github.com/user-attachments/assets/c19d050c-1f6a-46d1-baff-eae19ff37ab7"; /> **Task is executed successfully if a user is assigned both edit permission to DAG and HITL_Detail resource** <img width="1561" height="827" alt="Image" src="https://github.com/user-attachments/assets/89cdc3de-458f-44e3-99e9-3689f33cb644"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
