feluelle commented on a change in pull request #6232: [AIRFLOW-5582] AutoCommit
in jdbc is missing get_autocommit
URL: https://github.com/apache/airflow/pull/6232#discussion_r344455717
##########
File path: tests/contrib/hooks/test_jdbc_hook.py
##########
@@ -49,6 +49,14 @@ def test_jdbc_conn_connection(self, jdbc_mock):
self.assertIsInstance(jdbc_conn, Mock)
self.assertEqual(jdbc_conn.name, jdbc_mock.return_value.name) #
pylint: disable=no-member
+ # Set autocommit
+ jdbc_hook.set_autocommit(jdbc_conn, False)
+ jdbc_conn.jconn.setAutoCommit.assert_called_with(False)
Review comment:
Can you create a separate function for this, please? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
