ianbuss opened a new pull request, #54442:
URL: https://github.com/apache/airflow/pull/54442
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In a recent change, the private_key parameter is left empty when
instantiating the JWTGenerator used to authenticate log serving requests for
in-progress tasks. Such requests use the shared secret_key instead. However,
leaving private_key unset means that it is automatically populated through the
attrs field factory and this leads to a failure in the post init which asserts
mutual exclusivity of secret_key and private_key. The result is stack traces in
the API Server logs like the following when retrieving "live" logs:
```
[2025-08-12T19:33:59.403+0000] {file_task_handler.py:907} ERROR - Could not
read served logs
Traceback (most recent call last):
File
"/usr/local/lib/python3.12/site-packages/airflow/utils/log/file_task_handler.py",
line 878, in _read_from_logs_server
response = _fetch_logs_from_service(url, rel_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File
"/usr/local/lib/python3.12/site-packages/airflow/utils/log/file_task_handler.py",
line 173, in _fetch_logs_from_service
generator = JWTGenerator(
^^^^^^^^^^^^^
File "<attrs generated methods
airflow.api_fastapi.auth.tokens.JWTGenerator>", line 34, in __init__
self.__attrs_post_init__()
File
"/usr/local/lib/python3.12/site-packages/airflow/api_fastapi/auth/tokens.py",
line 417, in __attrs_post_init__
raise ValueError("Exactly one of private_key and secret_key must be
specified")
ValueError: Exactly one of private_key and secret_key must be specified
```
The fix is to add back the explicit `private_key=None`, for which we have to
add a mypy type ignore comment as it does not seem to understand that `None` is
allowed for `AllowedPrivateKeys | None`.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
