kaxil commented on code in PR #54401:
URL: https://github.com/apache/airflow/pull/54401#discussion_r2273160896


##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2054,14 +2055,45 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
                 "Task requeue attempts exceeded max; marking failed. 
task_instance=%s",
                 ti,
             )
+            msg = f"Task was requeued more than 
{self._num_stuck_queued_retries} times and will be failed."
             session.add(
                 Log(
                     event="stuck in queued tries exceeded",
                     task_instance=ti.key,
-                    extra=f"Task was requeued more than 
{self._num_stuck_queued_retries} times and will be failed.",
+                    extra=msg,
                 )
             )
-            ti.set_state(TaskInstanceState.FAILED, session=session)
+
+            try:
+                dag = 
self.scheduler_dag_bag.get_dag_for_run(dag_run=ti.dag_run, session=session)

Review Comment:
   ```suggestion
                   dag = self.scheduler_dag_bag. get_dag(dag_run=ti.dag_run, 
session=session)
   ```



##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2054,14 +2055,45 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
                 "Task requeue attempts exceeded max; marking failed. 
task_instance=%s",
                 ti,
             )
+            msg = f"Task was requeued more than 
{self._num_stuck_queued_retries} times and will be failed."
             session.add(
                 Log(
                     event="stuck in queued tries exceeded",
                     task_instance=ti.key,
-                    extra=f"Task was requeued more than 
{self._num_stuck_queued_retries} times and will be failed.",
+                    extra=msg,
                 )
             )
-            ti.set_state(TaskInstanceState.FAILED, session=session)
+
+            try:
+                dag = 
self.scheduler_dag_bag.get_dag_for_run(dag_run=ti.dag_run, session=session)

Review Comment:
   ```suggestion
                   dag = self.scheduler_dag_bag.get_dag(dag_run=ti.dag_run, 
session=session)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to