ashb commented on PR #53122: URL: https://github.com/apache/airflow/pull/53122#issuecomment-3188002880
@potiuk I see it differently, and I'd say this is one of the cases where not using a shared dist and duplicating the code is better for readability -- this sort of case is exactly what I had in mind when I wrote this https://github.com/apache/airflow/tree/main/shared#be-thoughtful-about-what-you-add-under-here > ## Be Thoughtful about what you add under here > > Not every piece of code used in two distributions should be automatically placed in one of the shared libraries, and sometimes "just duplicate it" is the right approach to take. For example, if it's just a 5 or 10 line function and it's used in two places, it might be easier for future developers to understand if the function is in two places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
