guan404ming commented on code in PR #54522:
URL: https://github.com/apache/airflow/pull/54522#discussion_r2278475983
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/Dashboard.tsx:
##########
@@ -70,7 +71,9 @@ export const Dashboard = () => {
</Accordion.Root>
) : undefined}
<Heading order={2} size="2xl">
- {translate("welcome")}
+ {typeof instanceName === "string" && instanceName.trim() !== ""
Review Comment:
I'm a little bit not sure that should we trim it here? There might be
unusual case where the user actually wants it to be just a space like this:
<img width="1440" height="862" alt="image"
src="https://github.com/user-attachments/assets/62f64f30-a95b-4988-afcf-d13f53a546c6";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
