ashb commented on code in PR #54256:
URL: https://github.com/apache/airflow/pull/54256#discussion_r2278970941


##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -509,6 +509,19 @@ core:
       type: string
       example: ~
       default: ~
+    template_searchpath:
+      description: |
+        Path where Airflow looks for Jinja templates used in DAGs and task 
fields.
+        Can be a single absolute path (string) or a comma-separated list of 
multiple
+        absolute paths.
+        When multiple paths are specified, Airflow searches them in the 
provided order
+        until the requested template file is found. Relative paths are 
resolved against
+        `AIRFLOW_HOME`.
+      version_added: ~
+      type: string
+      example: "/opt/airflow/dags/templates,/opt/airflow/cutom_templates"
+      default: "{AIRFLOW_HOME}/dags/include"

Review Comment:
   Two things
   
   1. I think this _shouldn't_ have a default. If you want to specify it on 
your install go for it, but don't make it on by default
   2. In Airflow 3, when you use a Git based Dag versioning then 
`$AIRFLOW_HOME/dags` _will not exist_. The dags aren't checked out in to there, 
so this default still won't really work in a number of cases.
   
   Which makes me think that the search path should not be a global setting, 
but a per dag bundle manager setting (by default Airflow uses a "Local" dag 
bundle)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to