mik-laj commented on a change in pull request #6530: [AIRFLOW-5878] Use JobID
to monitor statuses when running a Dataflow …
URL: https://github.com/apache/airflow/pull/6530#discussion_r344520951
##########
File path: tests/gcp/hooks/test_dataflow.py
##########
@@ -346,6 +348,15 @@ def test_start_template_dataflow_with_runtime_env(self,
mock_conn, mock_dataflow
gcsPath=TEMPLATE,
body=body,
)
+ mock_dataflowjob.assert_called_once_with(
+ dataflow=mock_conn.return_value,
+ job_id=TEST_JOB_ID,
+ location='us-central1',
+ name='test-dataflow-pipeline-{}'.format(MOCK_UUID),
+ num_retries=5,
+ poll_sleep=10,
+ project_number='test'
+ )
Review comment:
This mock is being checked because the result of calling this function
appears in tests, but I've added assertions. Updated. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
