ramitkataria commented on PR #54485: URL: https://github.com/apache/airflow/pull/54485#issuecomment-3193139232
@amoghrajesh I thought about it more and realized that there's a case where replacing `raise` with `log.exception` could do more harm than good: if the user specifies an `aws_conn_id` and some error occurred in airflow that raised an exception while fetching the connection, it would switch to using boto fallback credentials, just like the case where no `aws_conn_id` is specified. This could cause some operation to occur in an AWS account/role different from what the user intended. So I think the merged change is good and it keeps the behaviour consistent with earlier versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
