aritra24 commented on code in PR #54585: URL: https://github.com/apache/airflow/pull/54585#discussion_r2280860765
########## AGENTS.md: ########## @@ -0,0 +1,47 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + --> + +# AGENTS instructions Review Comment: Is this file intentionally added? Seems unrelated to prek. I'm okay with agent instructions being added, but just wanted to confirm. ########## Dockerfile.ci: ########## @@ -584,20 +584,19 @@ function common::install_packaging_tools() { pip install --root-user-action ignore --disable-pip-version-check "uv==${AIRFLOW_UV_VERSION}" fi fi - if [[ ${AIRFLOW_PRE_COMMIT_VERSION=} == "" ]]; then + if [[ ${AIRFLOW_PREK_VERSION=} == "" ]]; then echo - echo "${COLOR_BLUE}Installing latest pre-commit with pre-commit-uv uv${COLOR_RESET}" + echo "${COLOR_BLUE}Installing latest preh, uv${COLOR_RESET}" Review Comment: Same ########## Dockerfile.ci: ########## @@ -1314,7 +1313,7 @@ ENV DEV_APT_COMMAND=${DEV_APT_COMMAND} \ ARG AIRFLOW_PYTHON_VERSION=v3.10.18 ENV AIRFLOW_PYTHON_VERSION=$AIRFLOW_PYTHON_VERSION -ENV GOLANG_MAJOR_MINOR_VERSION=1.24.6 +ENV GOLANG_MAJOR_MINOR_VERSION=1.25.0 Review Comment: Do we want to bump up golang version right now? Not sure what our stance of golang version support is and timeframe for version bumps. ########## Dockerfile: ########## @@ -615,20 +615,19 @@ function common::install_packaging_tools() { pip install --root-user-action ignore --disable-pip-version-check "uv==${AIRFLOW_UV_VERSION}" fi fi - if [[ ${AIRFLOW_PRE_COMMIT_VERSION=} == "" ]]; then + if [[ ${AIRFLOW_PREK_VERSION=} == "" ]]; then echo - echo "${COLOR_BLUE}Installing latest pre-commit with pre-commit-uv uv${COLOR_RESET}" + echo "${COLOR_BLUE}Installing latest preh, uv${COLOR_RESET}" Review Comment: Typo ########## contributing-docs/06_development_environments.rst: ########## @@ -57,9 +57,9 @@ Limitations: Breeze container-based solution provides a reproducible environment that is consistent with other developers. -- You are **STRONGLY** encouraged to also install and use `pre-commit hooks <08_static_code_checks.rst#pre-commit-hooks>`_ +- You are **STRONGLY** encouraged to also install and use `prek hooks <08_static_code_checks.rst#prekt-hooks>`_ Review Comment: Is this a typo prekt/prek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
