potiuk commented on issue #54587: URL: https://github.com/apache/airflow/issues/54587#issuecomment-3194375659
I think there are two concerns mixed here: 1) languge 2) accessibility 2) security My suggestion is, if you are going to try to address those issues, is to split it into three, separate PRs. Also on top of the - undoubtedly - AI-generated generic advices, those PRs shoudl contain a little bit more of application of the advices to our specific cases: For 1) and 2), it would be great if you apply in your PRs using of the language translation framework we already have - as you might not realise in Airflow 3.1 we will have airflow UI translated into ~10 different languages. Any approach you do fo both 1) and 2) should include applying tha right language selected by the user to the generated pages. For 3) - I thi you you need to explain in your PR in detal (and refer to the source documenationat) what kind of effect you expect by adding "allow-scripts" - i.e. what currently lack of the "allow-scripts" causes and what will be fixed (and what kind of security boundaries, sandboxing properties are changed - and how after applying this clause. Also how it impacts the current approach of ui plugins that are going to be released in 3.1 Both language selection framework and UI plugins are already merged in `main` If you apply your understanding and understanding of those - feel free to proceed. Assigned you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
