ashb commented on code in PR #54547:
URL: https://github.com/apache/airflow/pull/54547#discussion_r2280944856
##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -610,6 +610,11 @@ def _read(
local_logs: list[RawLogStream] = []
executor_logs: list[RawLogStream] = []
served_logs: list[RawLogStream] = []
+ is_in_not_finished_state = ti.state in (
+ TaskInstanceState.RUNNING,
+ TaskInstanceState.DEFERRED,
+ TaskInstanceState.UP_FOR_RETRY
Review Comment:
I'm not convinced by this -- if a task is un UP_FOR_RETRY, it is no longer
actively running on a worker, and as far as logs are concerned it should be in
exactly the same as if it was in SUCCESS or FAILED state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
