jason810496 commented on PR #54582: URL: https://github.com/apache/airflow/pull/54582#issuecomment-3197427713
Hi @potiuk, I just checked the usage of `eks_get_token`, and it appears to be a special case. The `EksHook.execute` method writes the kubeconfig file using `generate_config_file`: https://github.com/apache/airflow/blob/9b46d76ee4fffdbefa7fa14aba5b7d8a8ec15f3b/providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py#L1067-L1075 The `generate_config_file` function leverages the `eks_get_token` module to generate the kubeconfig via `EksHook.fetch_access_token_for_cluster`: https://github.com/apache/airflow/blob/9b46d76ee4fffdbefa7fa14aba5b7d8a8ec15f3b/providers/amazon/src/airflow/providers/amazon/aws/hooks/eks.py#L540-L617 This PR is more of a quick fix to resolve https://github.com/apache/airflow/issues/53578. To fully address the issue without directly accessing the ORM, we would need to introduce a new `CommsDecoder` for this case. That would require more effort and could be taken up in a follow-up PR IMO. Additionally, @viiccwen, it would be great if you could test this fix with a real EKS setup, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
