potiuk commented on PR #53907: URL: https://github.com/apache/airflow/pull/53907#issuecomment-3198365283
I agree with Ash. We can always think about having "1-click approval" option later if users will want it, but simpler is better and more secure almost by definition, and this one has a potential to be abused or misused. It might even happen that users might find two-click solution better than 1-click in this case. Would be great to check it, but sometimes introducing a bit of friction is a good solution - especially in "corporate" context. I understand why Amazon likes 1-click but you yourself mentioned that for "cautious" users it's not the best solution, and I think being cautious in business workflows is the default. I think there is always a good reason why we are asking for approval. I don't imagine businesses would choose manual approval in otherwise automated workflows for anything that is not "serious" - because it needs a person to notice it and react - so I imagine vast majority of the "approvals" generated this way will be "rather serious". in this context having a confirmation /review screen where you actually *verify* what you confirm is a good idea. And it immediately solves all kinds of accidental clicks / mistakes that people can make. For example I REALLY love the feature of "undoing" whatever gmail action I've done. It saved me many, many, many timesm where things were "too easy" to accidentally trigger or where I had a chance to have "second thought". The UI screen is this kind of chance to have second thought about the action just done. > P.S.: If we decide not to merge this feature and have this discussion here in the PR I think we don't need to be super-formal with devlist if we majority decide here to de-scope this. Let's. FIrst let's see however if maybe we can achieve consensus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
