dabla commented on PR #54598: URL: https://github.com/apache/airflow/pull/54598#issuecomment-3199458093
> @dabla thanks overall LGTM, some tests needs to be fixed. > > BTW this is complete breaking change for AF2 users or anyone using these hooks methods , because `get_conn` is now async awaitable. so its better to add some compatibility and throw warning to users ? > > Offcourse this change must for this operator to work with AF3. We could but normally this is an "internal" method, as user would normally not interact with it when using operator of even the hook as there you have the run method. WDYT as get_conn is expected to be async now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
