ashb commented on code in PR #54449:
URL: https://github.com/apache/airflow/pull/54449#discussion_r2284586382
##########
airflow-core/tests/unit/cli/commands/test_task_command.py:
##########
@@ -174,7 +174,14 @@ def test_test_filters_secrets(self, capsys):
Output should be filtered by SecretsMasker.
"""
password = "somepassword1234!"
- logging.getLogger("airflow.task").filters[0].add_mask(password)
+ masker = logging.getLogger("airflow.task").filters[0]
+ masker.add_mask(password)
+
+ from airflow._shared.secrets_masker.secrets_masker import
_secrets_masker
+
+ shared_masker = _secrets_masker()
+ shared_masker.add_mask(password)
+
Review Comment:
This looks suspect -- we shouldn't to add the mask in both places (it
should be a duplicate mask I think)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
