pierrejeambrun commented on code in PR #54302:
URL: https://github.com/apache/airflow/pull/54302#discussion_r2284777780
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -526,8 +528,14 @@ def to_orm(self, select: Select) -> Select:
if self.value and self.value.lower_bound:
select = select.where(self.attribute >= self.value.lower_bound)
+ if self.value and self.value.lower_bound_excluded:
+ select = select.where(self.attribute >
self.value.lower_bound_excluded)
+
Review Comment:
Lets revert to your original idea, this is making thing overly complicated.
If a value is defined, apply the filter. And yes if both lt and lte filters are
defined for instance, both filters will be applied and the database will take
care of filtering the relevant results.
Sorry for the back and forth, I didn't think about the case mentioned above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
