dejii commented on PR #54494: URL: https://github.com/apache/airflow/pull/54494#issuecomment-3200157646
> Nice! Thanks for the PR! > > However, we may need to hold off on merging this until [Refactor Common Queue Interface #54651](https://github.com/apache/airflow/pull/54651) is merged. > > As we discuss in [#53556 (comment)](https://github.com/apache/airflow/pull/53556#discussion_r2265242503), there are some drawbacks to using Queue URI, and we should replace Queue URI with just "scheme". > > In the meantime, it would be nice to take [000b6c3](https://github.com/apache/airflow/commit/000b6c301eaf874ff239cbf980a9b0e4f13f9b07) as a guide for replacing the "Queue" logic with "Scheme" logic. > > Thanks! Thanks! I just went through the `scheme` logic and it looks solid. One question I had - do we have a standard for generating scheme names? Or is it decided ad hoc based on the queue type, as long as we make sure it doesn’t collide with existing ones? If not, inspired by the `redis+pubsub` scheme, would it make sense to adopt a consistent pattern like `<provider>+<queue>`? For this PR, that would mean using `google+pubsub` as the scheme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
