houqp commented on a change in pull request #6484: [AIRFLOW-5832] add pagerduty hook URL: https://github.com/apache/airflow/pull/6484#discussion_r344920107
########## File path: airflow/contrib/hooks/pagerduty_hook.py ########## @@ -0,0 +1,128 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Hook for creating Pagerduty incidents.""" +from typing import Any, Dict, List, Optional + +import pypd + +from airflow.exceptions import AirflowException +from airflow.hooks.base_hook import BaseHook + + +class PagerdutyHook(BaseHook): + """ + Takes both Pagerduty API token directly and connection that has Pagerduty API token. + + If both supplied, Pagerduty API token will be used. + + :param token: Pagerduty API token + :param pagerduty_conn_id: connection that has Pagerduty API token in the password field + """ + + def __init__(self, token: Optional[str] = None, pagerduty_conn_id: Optional[str] = None) -> None: + self.routing_key = None + + if pagerduty_conn_id is not None: + conn = self.get_connection(pagerduty_conn_id) + self.token = conn.get_password() Review comment: I started with `password`, but noticed it's just a wrapper around get_password and set_password, so I figured it's more efficient(less func call) and readable(less magic) to use `get_password` here instead since we only need to read the content. Let me know if you still think the `password` wrapper is more readable though, i am more than happy to change it :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
