guan404ming commented on code in PR #54670:
URL: https://github.com/apache/airflow/pull/54670#discussion_r2285754525
##########
providers/standard/src/airflow/providers/standard/triggers/hitl.py:
##########
@@ -107,7 +107,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
)
return
- await sync_to_async(update_htil_detail_response)(
+ await sync_to_async(update_hitl_detail_response)(
Review Comment:
> Need to be careful here! Since it depends on the Task SDK version. So if
older Task SDK version is used, this method won't exist! so you probably need a
try..except unfortunately --- unless this version of Standard provider hasn't
been released!
Thanks for pointing it out! I noticed we already have this in code,
https://github.com/apache/airflow/blob/3c4cdf4feb261fddf43fc16c69343b957267e63c/providers/standard/src/airflow/providers/standard/triggers/hitl.py#L22-L23
so I didn’t add `try..except` here. Do you think we should still add it to
ensure backward compatibility, or is it fine as is since like you said the
feature is not usable before 3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
