kaxil commented on code in PR #54505: URL: https://github.com/apache/airflow/pull/54505#discussion_r2285940809
########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py: ########## @@ -28,8 +28,8 @@ from airflow.api_fastapi.core_api.datamodels.extra_links import ExtraLinkCollectionResponse from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc from airflow.api_fastapi.core_api.security import DagAccessEntity, requires_access_dag -from airflow.exceptions import TaskNotFound from airflow.models import DagRun +from airflow.sdk.exceptions import TaskNotFound Review Comment: We shouldn't import exception from Task SDK in core and vice-versa ########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py: ########## @@ -35,9 +35,9 @@ from airflow.api_fastapi.core_api.datamodels.log import ExternalLogUrlResponse, TaskInstancesLogResponse from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc from airflow.api_fastapi.core_api.security import DagAccessEntity, requires_access_dag -from airflow.exceptions import TaskNotFound from airflow.models import TaskInstance, Trigger from airflow.models.taskinstancehistory import TaskInstanceHistory +from airflow.sdk.exceptions import TaskNotFound Review Comment: We shouldn't import exception from Task SDK in core and vice-versa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
