BasPH commented on a change in pull request #6549: [AIRFLOW-5880] Enforce
unique task ids
URL: https://github.com/apache/airflow/pull/6549#discussion_r345093469
##########
File path: airflow/models/baseoperator.py
##########
@@ -528,7 +528,7 @@ def dag(self, dag):
elif self.has_dag() and self.dag is not dag:
raise AirflowException(
"The DAG assigned to {} can not be changed.".format(self))
- elif self.task_id not in dag.task_dict:
+ elif self.task_id:
Review comment:
I'm missing a `if self.task_id in dag.task_dict` check and raising of
`DuplicateTaskIdFound`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
