amoghrajesh commented on code in PR #54774:
URL: https://github.com/apache/airflow/pull/54774#discussion_r2291177291
##########
airflow-core/src/airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -617,14 +617,17 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
elif success == 0:
yield self._failing_status(
reason=(
- f"Task's trigger rule '{trigger_rule}' requires
all non-skipped upstream tasks to have "
+ f"Task's trigger rule '{trigger_rule.value}'
requires all non-skipped upstream tasks to have "
f"completed and at least one upstream task has
succeeded, but found "
f"{success} successful task(s).
upstream_states={upstream_states}, "
f"upstream_task_ids={task.upstream_task_ids}"
)
)
else:
- yield self._failing_status(reason=f"No strategy to evaluate
trigger rule '{trigger_rule}'.")
+ print("true rule not implemented:", trigger_rule)
+ yield self._failing_status(
+ reason=f"No strategy to evaluate trigger rule
'{getattr(trigger_rule, 'value', trigger_rule)}'."
Review Comment:
> use-subclass-enum=true # enum, not union of Literals
@ashb
is already present in the pyproject.toml for task-sdk, the problem is that
__str__ is defined on the core version and when we generate the sdk version, it
gets removed, I could edit the `datamodel_code_formatter.py` script but I do
not think its worth that effort, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
