Lee-W commented on PR #54783:
URL: https://github.com/apache/airflow/pull/54783#issuecomment-3212934964

   > Thanks for adding this feature. That totally makes sense. Just I am not 
100% good with the choice of implementation. Similar we had in Airflow 2.x for 
the trifger form (and I just noticed that this feature is not implemented in 
3.x... so need to clean docs...) - if you take alook to 
[airflow.apache.org/docs/apache-airflow/stable/core-concepts/params.html](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/params.html):
   > 
   > > To pre-populate values in the form when publishing a link to the trigger 
form you can call the trigger URL /dags/<dag_name>/trigger and add query 
parameter to the URL in the form name=value, for example 
/dags/example_params_ui_tutorial/trigger?required_field=some%20text. To 
pre-define the run id of the DAG run, use the URL parameter run_id.
   > 
   > Can you make it for the feature here the same, so that no `params={...}` 
need to be used but you can directly call via 
`http://.../required_actions?key=value`?
   
   Not sure whether it's ideal in this case as we have both `options` and 
`params` here. If we do things this way, it will be confusing when users want 
something like `params_input={"options": ...}` (it probably doesn't make as 
much sense but should be valid)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to