amoghrajesh commented on code in PR #54449: URL: https://github.com/apache/airflow/pull/54449#discussion_r2292794618
########## airflow-core/src/airflow/settings.py: ########## @@ -717,10 +717,6 @@ def initialize(): HIDE_SENSITIVE_VAR_CONN_FIELDS = conf.getboolean("core", "hide_sensitive_var_conn_fields") -# By default this is off, but is automatically configured on when running task -# instances -MASK_SECRETS_IN_LOGS = False Review Comment: Handled differently now, moved the property inside of the `SecretsMasker` class so that we do not have to have `airflow.settings` imports in the shared module and also this way of doing things felt weird :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org