kyungjunleeme commented on code in PR #54684:
URL: https://github.com/apache/airflow/pull/54684#discussion_r2293147458


##########
providers/google/src/airflow/providers/google/cloud/triggers/pubsub.py:
##########
@@ -33,55 +33,60 @@ class PubsubPullTrigger(BaseTrigger):
     """
     Initialize the Pubsub Pull Trigger with needed parameters.
 
+    :param subscription: the Pub/Sub subscription name. Do not include the 
full subscription path
     :param project_id: the Google Cloud project ID for the subscription 
(templated)
-    :param subscription: the Pub/Sub subscription name. Do not include the 
full subscription path.
-    :param max_messages: The maximum number of messages to retrieve per
-        PubSub pull request
-    :param ack_messages: If True, each message will be acknowledged
-        immediately rather than by any downstream tasks
     :param gcp_conn_id: Reference to google cloud connection id
-    :param poke_interval: polling period in seconds to check for the status
     :param impersonation_chain: Optional service account to impersonate using 
short-term
         credentials, or chained list of accounts required to get the 
access_token
         of the last account in the list, which will be impersonated in the 
request.
         If set as a string, the account must grant the originating account
         the Service Account Token Creator IAM role.
         If set as a sequence, the identities from the list must grant
         Service Account Token Creator IAM role to the directly preceding 
identity, with first
-        account from the list granting this role to the originating account 
(templated).
+        account from the list granting this role to the originating account 
(templated)
+
+    :param max_messages: The maximum number of messages to retrieve per
+        PubSub pull request
+    :param ack_messages: If True, each message will be acknowledged
+        immediately rather than by any downstream tasks
+    :param poke_interval: polling period in seconds to check for the status
+    :param waiter_delay: The time in seconds to wait between calls to the SQS 
API to receive messages

Review Comment:
   Hello :) I'm just curious. 
   Are these comments generated through a VS Code extension?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to