potiuk commented on PR #54798: URL: https://github.com/apache/airflow/pull/54798#issuecomment-3215033469
> We also don't need airflowctl source tarball, the wheel and sdist are enough like Task SDK. Just for posterity I think that is not entirely correct. I have a task on me to fix it for providers, but we should do it for airflowctl "correctly" (but I agree not necessarily now) - see https://github.com/apache/airflow/issues/47343 I've learned recently that technically speaking .sdist is not "enough" - but I have to do a more accurate and complete provider's separation / isolation to complete it. The sources shoudl also allow to run "tests" and build "docs" and we do not have them with providers. This is not a big deal because currently whenever we release "airflow" - the tarball we release also contains providers (and airflowctl in 3.1 and task-sdk) sources - including tests and docs. So this is - not a huge deal but we will have to sort it out. For `task-sdk` in 3.0.* this is not an issue at all - because task-sdk, airflow and airflow-core are currently released together and airflow-src.tar.gz covers all of those. This will however change in 3.1 as we will start releasing it separately. I do not want to complicate it too much - and I think (after some deliberation) that we should simply get a complete airflow tarball per "release" - i.e. when we prepare "providers" release from main, we should also prepare a source tarball with complete repository - but name it something like "airflow-providers-2025-11-07-src.tar.gz . Similarly for task-sdk/airflowctl, this could be "airflow-task-sdk-1.1.x-src.tar.gz" and for airflow-ctl `airflow-airflowctl-0.0.x-src.tar.gz`. Each of those will be the same - complete snapshot of airlfow monorepo with everything - maybe we could dynamically update INSTALL or README inside to add instructions how to build that specific package (or maybe we should just make those files contains conditional "if you want to build this - do that" etc. Similarly it should contain instructions on how to build docs and run tests. Luckily with the new approach and stardisation, it's as easy as: * tests: "cd RIGHT_DIR; uv run pytest" * docs: "cd RIGHT_DIR; uv run --group docs build-docs` I think that will be the simplest way, In short - indeed we likely do not need separate airflow-ctl, we just need to update the existing airflow tarbal to produce rightly named `*-src.tar.gz` WDYT: @kaxil @bugraoz93 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
