bbovenzi commented on code in PR #54252: URL: https://github.com/apache/airflow/pull/54252#discussion_r2294710745
########## airflow-core/src/airflow/ui/src/pages/Dag/Calendar/DailyCalendarView.tsx: ########## @@ -0,0 +1,140 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Box, Text } from "@chakra-ui/react"; +import dayjs from "dayjs"; +import { useTranslation } from "react-i18next"; + +import type { CalendarTimeRangeResponse } from "openapi/requests/types.gen"; + +import { CalendarTooltip } from "./CalendarTooltip"; +import { createTooltipContent, generateDailyCalendarData, getCalendarCellColor } from "./calendarUtils"; +import type { CalendarColorMode } from "./types"; +import { useDelayedTooltip } from "./useDelayedTooltip"; + +type Props = { + readonly colorMode: CalendarColorMode; + readonly data: Array<CalendarTimeRangeResponse>; + readonly selectedYear: number; +}; + +export const DailyCalendarView = ({ colorMode, data, selectedYear }: Props) => { + const { t: translate } = useTranslation("dag"); + const dailyData = generateDailyCalendarData(data, selectedYear); + const { handleMouseEnter, handleMouseLeave } = useDelayedTooltip(); + + const weekdays = [ + translate("calendar.weekdays.sunday"), + translate("calendar.weekdays.monday"), + translate("calendar.weekdays.tuesday"), + translate("calendar.weekdays.wednesday"), + translate("calendar.weekdays.thursday"), + translate("calendar.weekdays.friday"), + translate("calendar.weekdays.saturday"), + ]; + + return ( + <Box mb={4}> + <Box display="flex" mb={2}> + <Box width="50px" /> + <Box display="flex" gap={1}> + {dailyData.map((week, index) => ( + <Box key={`month-${week[0]?.date ?? index}`} position="relative" width="18px"> + {Boolean(week[0] && dayjs(week[0].date).date() <= 7) && ( + <Text color="fg.muted" fontSize="xs" left="0" position="absolute" top="-20px"> + {dayjs(week[0]?.date).format("MMM")} + </Text> + )} + </Box> + ))} + </Box> + </Box> + <Box display="flex" gap={2}> + <Box display="flex" flexDirection="column" gap={1}> + {weekdays.map((day) => ( + <Box + alignItems="center" + color="fg.muted" + display="flex" + fontSize="xs" + height="18px" + justifyContent="flex-end" + key={day} + pr={2} + width="40px" + > + {day} + </Box> + ))} + </Box> + <Box display="flex" gap={1}> + {dailyData.map((week, weekIndex) => ( + <Box display="flex" flexDirection="column" gap={1} key={`week-${week[0]?.date ?? weekIndex}`}> + {week.map((day) => { + const dayDate = dayjs(day.date); + const isInSelectedYear = dayDate.year() === selectedYear; + + if (!isInSelectedYear) { + return <Box bg="transparent" height="18px" key={day.date} width="18px" />; + } + + return ( + <Box + key={day.date} + onMouseEnter={handleMouseEnter} + onMouseLeave={handleMouseLeave} + position="relative" + > + <Box + _hover={{ transform: "scale(1.1)" }} + bg={getCalendarCellColor(day.runs, colorMode)} + borderRadius="2px" + cursor="pointer" + height="18px" + width="18px" Review Comment: First, we specify this cells a ton. I wonder if we can consolidate it to a component to reuse. Second, I agree with Jens. Its very large. What if we set it to 14x14 to match the grid view? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
