abhishekbhakat commented on PR #54775:
URL: https://github.com/apache/airflow/pull/54775#issuecomment-3219155427

   @alvinzhangdd 
   
   If a task’s end_date is a Jinja template string and gets stored in 
serialized_dag, deserialization will keep it
   as that string (no coercion, no default).
   
   The field will not be null; it stays a string. That can break scheduling 
later:
     - RunnableExecDateDep compares `logical_date > ti.task.end_date` and calls 
`.isoformat()` on it. A string `end_date` will raise a TypeError/AttributeError 
at this check.
     - If it had been `None`, there would be no issue (no comparisons done).
   
   But I don't believe setting it as None is helpful. If anything, it just 
promotes bad dag writing practices.
   Let me see if I can raise a broken dag error instead to let user fix the 
problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to