potiuk commented on code in PR #54523:
URL: https://github.com/apache/airflow/pull/54523#discussion_r2298422862
##########
airflow-core/src/airflow/executors/local_executor.py:
##########
@@ -186,8 +186,7 @@ def _check_workers(self):
# If we're using spawn in multiprocessing (default on macOS now) to
start tasks, this can get called a
# via `sync()` a few times before the spawned process actually starts
picking up messages. Try not to
# create too much
- need_more_workers = len(self.workers) < num_outstanding
- if need_more_workers and (self.parallelism == 0 or len(self.workers) <
self.parallelism):
+ if num_outstanding and (self.parallelism == 0 or len(self.workers) <
self.parallelism):
Review Comment:
I added test cases in
https://github.com/aws-mwaa/upstream-to-airflow/pull/15 -> adding a comment
here so that this PR is not merged without them,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
