vincbeck opened a new pull request, #54926: URL: https://github.com/apache/airflow/pull/54926
Resolves #53936. Follow-up of #54197. The way `FabAuthManager` checks for Dag permission is partially broken in multiple ways: 1. To check whether user is authorized to list Dags, we are calling `get_authorized_dag_ids` (which returns the list of Dags the user is authorized to access) and checking whether this list is not empty. Even though this is not strictly wrong, it is not good either. A more robust solution proposed by @pierrejeambrun (see thread [here](https://github.com/apache/airflow/pull/54197#pullrequestreview-3101266838) for more information about the solution but also the reason why it is better) is to check whether the user has either access to all Dags or at least one dag permission with `RESOURCE_DAG_PREFIX` 2. I remove `RESOURCE_DAG_RUN_PREFIX` because I think this is very wrong. The purpose of this constant (value is `DAG Run:`) is to be able to give access to Dag runs of specific Dags. Example: To give read access to user `X` of Dag runs of Dag `test`, I can add to the user's permissions `(CAN_READ, DAG Run:test)`. But this is possible without this constant, using the same example, to grant the user access to Dag `test` runs, you can give them `(CAN_READ, Dag:test)` and `(CAN_READ, RESOURCE_DAG_RUN)`. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
