ashb commented on issue #6342: [AIRFLOW-5662] fix incorrect naming for 
scheduler used slot metric
URL: https://github.com/apache/airflow/pull/6342#issuecomment-553020098
 
 
   Broadly your plan sounds sensible.
   
   > the task instance hasn't been scheduled to run yet, so it would be 
misleading to report the in memory value of the new open slot count as metric
   
   Yes and no. The memory value (via the `open_slots` local variable) is what 
the scheduler actually uses to make it's decision, so emitting metrics based on 
that is the most accurate view of what the scheduler is doing. (There's still a 
case where the scheduler is getting stuck without a trace and not passing tasks 
to the executor that we haven't tracked down)
   
   It's also possible that the value in the DB could change between the the two 
places. (i.e. a task could finish.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to