jscheffl commented on code in PR #54825: URL: https://github.com/apache/airflow/pull/54825#discussion_r2301936531
########## airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx: ########## Review Comment: Somehow some field types are broken now. All are handled now as datetime but there are also "date" (only) and "time" (only) types. See "date" time shows datetime picker and if you select something result is not applied: <img width="956" height="511" alt="Image" src="https://github.com/user-attachments/assets/082a03ab-4479-49be-bbb9-4f79955232e4"; /> Same for the "time" picker, also can not select: <img width="908" height="474" alt="Image" src="https://github.com/user-attachments/assets/384d1937-775a-47ae-b270-e5d496cf6849"; /> Maybe you revert the integration in FlexibleForm and make this a different PR? To test youself, start with example Dags (`breeze start-airflow --load-example-dags`) and test with the `Params UI tutorial` - that has a form with all important fields. ########## airflow-core/src/airflow/ui/src/components/DagActions/ReprocessBehaviorForm.tsx: ########## @@ -0,0 +1,55 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { HStack } from "@chakra-ui/react"; +import type { TFunction } from "i18next"; +import type { ControllerRenderProps } from "react-hook-form"; + +import { reprocessBehaviors } from "src/constants/reprocessBehaviourParams"; + +import { RadioCardItem, RadioCardLabel, RadioCardRoot } from "../ui/RadioCard"; +import type { BackfillFormProps } from "./RunBackfillForm"; + +type Props = { + readonly field: ControllerRenderProps<BackfillFormProps, "reprocess_behavior">; + readonly translate: TFunction; +}; + +export const ReprocessBehaviorForm = ({ field, translate }: Props) => ( + <RadioCardRoot + defaultValue={field.value} + onChange={(event) => { + field.onChange(event); + }} + > + <RadioCardLabel fontSize="md" fontWeight="semibold" mb={3}> + {translate("backfill.reprocessBehavior")} + </RadioCardLabel> + <HStack> Review Comment: nit: I had a fix recently, seems your re-work added the problem again. See: #54848 ```suggestion <HStack align="stretch"> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
