ashb commented on code in PR #54743:
URL: https://github.com/apache/airflow/pull/54743#discussion_r2304050015
##########
go-sdk/example/main.go:
##########
@@ -56,9 +56,9 @@ func extract(ctx context.Context, log *slog.Logger) error {
return nil
}
-func transform(ctx context.Context, log *slog.Logger) error {
+func transform(ctx context.Context, client sdk.Client, log *slog.Logger) error
{
key := "my_variable"
- val, err := sdk.VariableGet(ctx, key)
+ val, err := client.GetVariable(ctx, key)
Review Comment:
Yeah, I was initially thinking the same as you, and this is a little bit
verbose but the total scope of domain objects we'll expose via this is (I
think) Variables, Connections, XCom, and then possible DR and TI for other
status checks, so while verbose this is not so bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
