yangyulely opened a new pull request, #55008:
URL: https://github.com/apache/airflow/pull/55008
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Why
- The `bulk_load`, `bulk_dump`, and `bulk_load_custom` methods share common
code for establishing connections, creating cursors, committing transactions,
and closing connections. This can be extracted into a reusable context manager.
- The `bulk_load` and `bulk_dump` methods do not explicitly close the
database cursor. Using a context manager will ensure that both the connection
and cursor are always closed properly, even if errors occur.
- Encapsulating the connection and cursor logic within a context manager
will make the bulk operation methods cleaner and easier to understand.
## How
__1. Introduce a Context Manager for Connection and Cursor Handling__
A new private method, `_get_cursor`, will be added to manage the lifecycle
of database connections and cursors.
__2. Refactor Bulk Operation Methods__
The methods `bulk_load`, `bulk_dump`, and `bulk_load_custom` will be updated
to use the new `_get_cursor` context manager. This will remove duplicated code
for connection, cursor creation, committing, and closing, making the methods
cleaner and more robust.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
