feluelle commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r345494522
##########
File path: airflow/utils/state.py
##########
@@ -99,6 +99,7 @@ def finished(cls):
cls.SUCCESS,
cls.FAILED,
cls.SKIPPED,
+ cls.UPSTREAM_FAILED
Review comment:
I absolutely agree with what Ash is saying. The documentation doesn’t match
the implementation and the change would probably need a separate ticket,
because it changes the basic concept or meaning of finished tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services