shreyaskj-0710 commented on code in PR #54341: URL: https://github.com/apache/airflow/pull/54341#discussion_r2306876444
########## airflow-core/src/airflow/api_fastapi/common/parameters.py: ########## @@ -607,6 +629,7 @@ def depends_float( ] QueryTagsFilter = Annotated[_TagsFilter, Depends(_TagsFilter.depends)] QueryOwnersFilter = Annotated[_OwnersFilter, Depends(_OwnersFilter.depends)] +QueryTimeTableTypesFilter = Annotated[_TimetableTypesFilter, Depends(_TimetableTypesFilter.depends)] Review Comment: Hi @jason810496 , Thanks for the suggestion! I noticed that other filters in this area were implemented as classes, so I followed the same pattern to keep things consistent and make the available filters easier to discover. That said, I’m open to refactoring this to use filter_param_factory if we’d like to align with newer patterns (like in the event_logs route). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
