bugraoz93 commented on code in PR #54798:
URL: https://github.com/apache/airflow/pull/54798#discussion_r2312137360
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -523,14 +534,17 @@ def remove_old_releases(version, repo_root):
@release_management.command(
name="prepare-airflow-tarball",
- help="Prepare airflow's source tarball.",
+ help="Prepare airflow's or airflow distribution source tarball.",
)
@click.option(
"--version", required=True, help="The release candidate version e.g.
2.4.3rc1", envvar="VERSION"
)
[email protected](
+ "--distribution-name", default="airflow", help="The distribution name,
airflow, task-sdk, airflowctl"
Review Comment:
Thanks for your comments, Jarek! :) I addressed them.
Hope I made the changes to the release processes correctly, please
double-check :) I have added a tag to specify to `git archive`, and if it is
passed, the distribution commands also generate a source tarball. Or still
`breeze release-management prepare-airflow-tarball` can be used.
The `tag` logic was also added in general because sometimes a version
without rc does not correspond to a tag, and since only `airflow-core` version
matching with tag names such as `3.0.6`, this makes other distributions a bit
not testable and working in a couple of cases. This stabilises and lets say we
can give `airflowctl/1.0.0b1,` but still can create 1.0.0 source tar.
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -523,14 +534,17 @@ def remove_old_releases(version, repo_root):
@release_management.command(
name="prepare-airflow-tarball",
- help="Prepare airflow's source tarball.",
+ help="Prepare airflow's or airflow distribution source tarball.",
)
@click.option(
"--version", required=True, help="The release candidate version e.g.
2.4.3rc1", envvar="VERSION"
)
[email protected](
+ "--distribution-name", default="airflow", help="The distribution name,
airflow, task-sdk, airflowctl"
Review Comment:
Thanks for your comments, Jarek! :) I addressed them.
Hope I made the changes to the release processes correctly, please
double-check :) I have added a tag to specify to `git archive`, and if it is
passed, the distribution commands also generate a source tarball. Or still
`breeze release-management prepare-airflow-tarball` can be used
The `tag` logic was also added in general because sometimes a version
without rc does not correspond to a tag, and since only `airflow-core` version
matching with tag names such as `3.0.6`, this makes other distributions a bit
not testable and working in a couple of cases. This stabilises and lets say we
can give `airflowctl/1.0.0b1,` but still can create 1.0.0 source tar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
