potiuk commented on PR #55119:
URL: https://github.com/apache/airflow/pull/55119#issuecomment-3241139563
Another comment. Maybe a better way would be to add the mechanism to fail
and unfreeze in selective checks. We already done that in the past and it has a
few nice properties:
1) It can fail FAST -> if selective checks check fails, no other job runs,
the PR fails almost immediately
2) we already have "changed files" built in and we can use it from there
3) we can use "labels" to make exemptions ("allow to modify translations"
for example) rather than commit "exemptions file". How it works (we do it
already) - we need to set a specified label on the PR to skip the check for
modified translations. So rather than finding out how to modify exemptions
files,a committer has to deliberately set "allow to moify translations") to let
the PR pass the selective checks.
4) you can unit test is with `test_selective_checks.py`
It's also very easy to test:
```
breeze ci selective-checks --commit-ref <HASH> --pr-labels "label"`
```
We do it already a very similar way if suspended providers are affected:
https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1376
Some pointers how we can do it:
* add a new property in SelectiveChecks "english_translation_affected" (it
will be automatically converted into output in GitHubActions
* make it return true if "en" translations are in "changed files"
https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L144
* in the property method check a constant (True) in this commit
"FAIL_IF_EN_TRANSLATION_MODIFIED" (for now - we can set to False when we want
to disable the check) and sys.exit(1) with the right error message if en
translation is in changed files unless "allow to modify translations" label is
set (similarly as we do in
https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
